Skip to content

Add country field support to subscribers API #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2025
Merged

Add country field support to subscribers API #809

merged 1 commit into from
Jul 20, 2025

Conversation

@oguzkocer
Copy link
Contributor

Summary

Adds support for the include parameter in the subscribers API to request additional fields such as country. Also fixes handling of country data when the API returns false instead of String for its fields.

Changes

  • Add include parameter to SubscribersListParams with support for country field
  • Make SubscriberCountry fields optional to handle API edge case where false is returned
  • Add integration test to verify country field inclusion works correctly

Breaking Changes

  • SubscriberCountry.code and SubscriberCountry.name are now Option<String> instead of String

@oguzkocer
Add country field support to subscribers API
c20ce17 
- Add `include` parameter to request country field for subscribers
- Make `SubscriberCountry` fields optional to handle API returning false
- Add integration test for country field inclusion

BREAKING CHANGE: `SubscriberCountry` fields are now optional
@oguzkocer oguzkocer added this to the 0.2 milestone Jul 18, 2025
@oguzkocer oguzkocer marked this pull request as ready for review July 18, 2025 00:55
@oguzkocer oguzkocer enabled auto-merge (squash) July 18, 2025 00:55
@oguzkocer oguzkocer requested a review from crazytonyli July 18, 2025 00:55
@oguzkocer oguzkocer merged commit 8abd219 into trunk Jul 20, 2025
20 checks passed
@oguzkocer oguzkocer deleted the include-country-in-subscribers branch July 20, 2025 23:30
@nbradbury nbradbury mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazytonyli crazytonyli crazytonyli approved these changes

Assignees

No one assigned

Labels

Endpoint Rust Testing

Projects

None yet

Milestone

0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@oguzkocer @crazytonyli